Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gardener credentials data keys #11

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Support Gardener credentials data keys #11

merged 1 commit into from
Dec 16, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Nov 29, 2020 •
edited
Loading

/area open-source usability
/kind enhancement
/priority normal
/platform gcp

What this PR does / why we need it:
All the secret keys used by Gardener are now also allowed as alternatives for this machine-controller-manager plugin. This helps to not make mappings for the data keys.

Special notes for your reviewer:
ℹ️ Similar improvement for in-tree driver: gardener/machine-controller-manager@0e41070 (gardener/machine-controller-manager#578)

Release note:

The machine class secret does now also accept the data key `serviceaccount.json` as alternatives for today's key.

@rfranzke rfranzke requested a review from a team as a code owner November 29, 2020 17:55
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure priority/normal needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 29, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 29, 2020
@rfranzke
Copy link
Member Author

rfranzke commented Dec 2, 2020

/assign @hardikdr @prashanth26 @amshuman-kr @AxiomSamarth

@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 2, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 2, 2020
prashanth26
prashanth26 approved these changes Dec 16, 2020
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Not sure how I missed this one.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 16, 2020
@prashanth26 prashanth26 merged commit f5df365 into master Dec 16, 2020
@prashanth26 prashanth26 deleted the enh/credentials branch December 16, 2020 11:18
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxiomSamarth AxiomSamarth AxiomSamarth approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees

@hardikdr hardikdr

@amshuman-kr amshuman-kr

@AxiomSamarth AxiomSamarth

@prashanth26 prashanth26

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rfranzke @AxiomSamarth @prashanth26 @hardikdr @amshuman-kr @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot