Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/machinedeployment freeze sync #264

Merged
merged 3 commits into from May 13, 2019
Merged

Bugfix/machinedeployment freeze sync #264

merged 3 commits into from May 13, 2019

Conversation

prashanth26
Copy link
Contributor

@prashanth26 prashanth26 commented May 9, 2019 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #250

Special notes for your reviewer:

Release note:

Bugfix: MachineDeployment with partial freeze status has been syncronized to display the correct status

@prashanth26 prashanth26 requested review from ggaurav10 and a team as code owners May 9, 2019 12:18
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 9, 2019
@prashanth26 prashanth26 added kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/review Needs review priority/critical Needs to be resolved soon, because it impacts users negatively size/s Size of pull request is small (see gardener-robot robot/bots/size.py) topology/seed Affects Seed clusters and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 10, 2019
@prashanth26
Machine deployment freeze state synchronizer
eaf1a3a 
Machine deployment was sometimes found in a partial freeze state where either of the label or status was missing.
This change fixes this by creating a machine deployment freeze state synchronizer
@prashanth26
Added tests for machine deployment freeze state synchronizer
36c0d58
@prashanth26
Removed LastUpdateTimestamp for machine sets
44b9ee6 
This field/functionality was no longer being used and hence being removed from the MCM code
@prashanth26 prashanth26 force-pushed the bugfix/machinedeployment-freeze-sync branch from 69c98e4 to 44b9ee6 Compare May 10, 2019 05:54
@prashanth26 prashanth26 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 10, 2019
@hardikdr hardikdr merged commit f9e82c9 into gardener:master May 13, 2019
@prashanth26 prashanth26 deleted the bugfix/machinedeployment-freeze-sync branch July 17, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/critical Needs to be resolved soon, because it impacts users negatively size/s Size of pull request is small (see gardener-robot robot/bots/size.py) topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idempotent machineSet and machineDeployment unfreeze
3 participants
@prashanth26 @hardikdr @gardener-robot-ci-1