Bugfix: Existing machine-object now adopts node-label #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
reviewed/ok-to-test
prashanth26
added
area/robustness
prashanth26
reviewed
May 13, 2019
| @@ -312,6 +312,20 @@ func (c *controller) updateMachineState(machine *v1alpha1.Machine) (*v1alpha1.Ma | |||
| if err != nil { | |||
| return machine, err | |||
| } | |||
|
|
|||
| if clone.Labels == nil { | |||
There was a problem hiding this comment.
I think we need to take a deepCopy before making the changes here?
There was a problem hiding this comment.
thanks, I wasn't really sure to deep-copy here. We can certainly deep-copy, do you have any possible reasoning to support it?
There was a problem hiding this comment.
From what I understand, we would be working from an object from the local cache directly. if we don't deep copy. Deep copying creates a local copy on this method and then acts on it.
There was a problem hiding this comment.
As discussed over a call, made few changes.
Thanks, this was a good catch..
hardikdr
force-pushed
the
bugfix-node-label
branch
from
a634053
to
bf24ddd
Compare
prashanth26
approved these changes
May 13, 2019
| @@ -312,6 +312,20 @@ func (c *controller) updateMachineState(machine *v1alpha1.Machine) (*v1alpha1.Ma | |||
| if err != nil { | |||
| return machine, err | |||
| } | |||
|
|
|||
| if clone.Labels == nil { | |||
prashanth26
added
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
ghost
added
the
component/mcm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We realized existing machine-objects were not picking up the node-label. This PR fixes that bug.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: