Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing user_domain_id secret field #328

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Added missing user_domain_id secret field #328

merged 1 commit into from
Aug 27, 2019

Conversation

afritzler
Copy link
Member

@afritzler afritzler commented Aug 26, 2019 •
edited
Loading

What this PR does / why we need it:
This PR adds the support for userDomainID as an authentication parameter.

Which issue(s) this PR fixes:
Relates to #311

Release note:

Added missing user_domain_id secret field for OpenStack driver

@afritzler afritzler requested review from ggaurav10 and a team as code owners August 26, 2019 12:32
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 26, 2019
@hardikdr hardikdr merged commit 6e2d0c7 into gardener:master Aug 27, 2019
@afritzler afritzler mentioned this pull request Jan 30, 2020
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afritzler @hardikdr @gardener-robot-ci-1