Update github.com/Azure/azure-sdk-for-go #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
gardener-robot-ci-1
added
reviewed/ok-to-test
|
@gardener/mcm-maintainers , any feedback? |
|
Thanks @ialidzhikov for the PR. We were checking if the upgrade of the vendor for Azure is breaking any of the functions semantically. As our integration test-pipeline is not enabled for Azure[explicitly disabled due to issues in past], I am wondering if you have tested your changes, if it works well?
|
|
Yes, I made a docker image and using |
|
I believe that should be sufficient then, thanks a lot. :) |
hardikdr
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Recently we faced issues vendoring machine-controller-manager in other projects - for example gardener/gardener-extensions#463. gardener/gardener-extensions refers
github.com/Azure/azure-sdk-for-go@v32.6.0while machine-controller-manager -v26.1.0. This PR updates also machine-controller-manager to usev32.6.0.Also
github.com/Azure/go-autorestis split into go submodules and this PR switches to the new submodule dependencies - ref https://github.com/Azure/go-autorest/#using-with-go-modules.Which issue(s) this PR fixes:
Ref gardener/gardener-extensions#463
Special notes for your reviewer:
Release note: