Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update status when replicas undefined or equal to zero #387

Merged
merged 1 commit into from Jan 17, 2020
Merged

Update status when replicas undefined or equal to zero #387

merged 1 commit into from Jan 17, 2020

Conversation

rewiko
Copy link
Contributor

@rewiko rewiko commented Jan 13, 2020 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes gardener/autoscaler#20

Special notes for your reviewer:

Machine-controller-manager is already working with zero replicas, but the status was not defined which means doing kubectl get machinedeployments will show blank. With the change it will set the replicas status to 0.

Release note:

Allow status to be defined when replicas is not defined or equal to 0.

- category:       improvement
- target_group:   user

@rewiko rewiko requested review from ggaurav10 and a team as code owners January 13, 2020 15:19
@rewiko rewiko mentioned this pull request Jan 13, 2020
Closed
hardikdr
hardikdr approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge soon once CI passes.
Thanks a lot for the PR :)

@hardikdr hardikdr added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 15, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 15, 2020
@hardikdr hardikdr added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2020
@hardikdr hardikdr merged commit 535de4f into gardener:master Jan 17, 2020
@rewiko rewiko deleted the update-status-when-replicas-undefined-or-equal-to-zero branch January 17, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support zero sized worker-pools
4 participants
@rewiko @hardikdr @gardener-robot-ci-1 @gardener-robot-ci-3