Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Cinder based Custom Root Disks for OpenStack Vms #388

Merged
merged 1 commit into from Jan 16, 2020
Merged

Added Cinder based Custom Root Disks for OpenStack Vms #388

merged 1 commit into from Jan 16, 2020

Conversation

afritzler
Copy link
Member

What this PR does / why we need it:
This PR extends the OpenStack MachineClass to support custom root disk size. It does this by adding a Cinder based root disk volume to the VM created via MCM.

To configure the root disk size the manifest looks like the following

apiVersion: machine.sapcloud.io/v1alpha1
kind: OpenStackMachineClass
metadata:
  name: test-openstack # Name of OpenStack machine class goes here
  namespace: default # Namespace in which the machine class is to be deployed
spec:
  ...
  rootDiskSize: 100 # 100 GB

The creation policy for the Cinder volume is DeleteOnTermination meaning that the volume gets removed when the machine is terminated.

Which issue(s) this PR fixes:
Fixes #386

Release note:

Added Cinder based root disk support with customisable disk size

@afritzler afritzler requested review from ggaurav10 and a team as code owners January 14, 2020 09:40
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 14, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 14, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 14, 2020
prashanth26
prashanth26 approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@prashanth26 prashanth26 merged commit bec07c7 into gardener:master Jan 16, 2020
@afritzler afritzler mentioned this pull request Jan 20, 2020
Merged
ialidzhikov
ialidzhikov reviewed Jan 23, 2020
View reviewed changes
pkg/apis/machine/v1alpha1/types.go
@@ -742,6 +742,7 @@ type OpenStackMachineClassSpec struct {
Networks []OpenStackNetwork `json:"networks,omitempty"`
SecretRef *corev1.SecretReference `json:"secretRef,omitempty"`
PodNetworkCidr string `json:"podNetworkCidr"`
RootDiskSize int `json:"rootDiskSize,omitempty"` // in GB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why resource.Quantity is not used?
g/g uses resource.Quantity for volume.size in the Shoot spec - ref https://github.com/gardener/gardener/blob/ab4ddfc16c0709b0d301ee8713f61fad7fcbeb6f/pkg/apis/core/v1beta1/types_cloudprofile.go#L136-L137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 ggaurav10 approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Root Disk Size for OpenStack Machines
8 participants
@afritzler @ialidzhikov @hardikdr @ggaurav10 @prashanth26 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3