Azure: Allow to manage machine with identity #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
prashanth26
added
reviewed/ok-to-test
Allow to create and manage Azure virtual machines which have an user assigned managed identity assigned to.
gardener-robot-ci-3
added
needs/ok-to-test
|
Thanks @ggaurav10. Should be done. |
prashanth26
added
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
prashanth26
added
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
hardikdr
approved these changes
Jan 27, 2020
ggaurav10
reviewed
Jan 27, 2020
| @@ -9834,7 +9798,7 @@ func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenA | |||
| Properties: map[string]spec.Schema{ | |||
| "replicas": { | |||
| SchemaProps: spec.SchemaProps{ | |||
| Description: "Replicas is the number of desired replicas. This is a pointer to distinguish between explicit zero and unspecified. Defaults to 0. More info: https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller#what-is-a-replicationcontroller", | |||
| Description: "Replicas is the number of desired replicas. This is a pointer to distinguish between explicit zero and unspecified. Defaults to 1. More info: https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller#what-is-a-replicationcontroller", | |||
There was a problem hiding this comment.
This shouldn't change with this PR. Is it a rebasing issue?
There was a problem hiding this comment.
This got in as hack/generatecode was not run previously. Though we need to check on the open-api generate-code path, as in reality it gets defaulted to 0, but not the concern of this PR.
hardikdr
requested changes
Jan 27, 2020
There was a problem hiding this comment.
This seems to be conflicting with previous PR - https://github.com/gardener/machine-controller-manager/pull/387/files#diff-9d94091c0a427369e10972836f35644fR9738
|
Hmm I just called |
|
Sure @dkistner, We haven't yet been able to look into it. We shall soon fix it and let you know. |
|
One of the recent PR dint run |
hardikdr
approved these changes
Jan 30, 2020
prashanth26
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to create and manage Azure virtual machines which have an user assigned managed identity assigned to.
What this PR does / why we need it:
Azure machines can now be deployed with an attached user assigned managed identity, which can be used to authenticate to other Azure services like ACR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: