Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort active machines by creation timestamp #429

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

prashanth26
Copy link
Contributor

@prashanth26 prashanth26 commented Mar 16, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #422

Special notes for your reviewer:

Release note:

Sort active machines by creation timestamp

@prashanth26 prashanth26 requested review from ggaurav10 and a team as code owners March 16, 2020 05:07
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 16, 2020
@hardikdr
Copy link
Member

Hi @prashanth26 , is this PR WIP yet ?

@prashanth26
Copy link
Contributor Author

prashanth26 commented Mar 19, 2020

Hi @hardikdr ,

Yes this is still a WIP. Finishing up some tests. Will update it here.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 24, 2020
@prashanth26 prashanth26 changed the title [WIP] Sort active machines by creation timestamp Sort active machines by creation timestamp Mar 24, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 24, 2020
@prashanth26
Copy link
Contributor Author

PR is reviewable.

@hardikdr hardikdr merged commit ca2c95d into gardener:master Mar 25, 2020
@prashanth26 prashanth26 deleted the fix/filter-active-machines branch May 2, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the sorting of machines while scaling down
5 participants