Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve machine creation and deletion flow by listing the machines before actual creation/deletion #432

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Improve machine creation and deletion flow by listing the machines before actual creation/deletion #432

merged 4 commits into from
Mar 27, 2020

Conversation

hardikdr
Copy link
Member

What this PR does / why we need it: This PR addresses the cases when an unfortunate restart of the MCM can make it lose the state. MCM now lists the VMs in the cloud, before actually creating or deleting the machines.

  • This PR also enables MCM to adopt the dynamically node-object in case it is not populated on the machine-object while creation.

Which issue(s) this PR fixes:
Fixes #423
Special notes for your reviewer:

Release note:

Improves the machine-creation and machine-deletion flow by listing and verifying the state of the machines before actual creation and deletion. 

MCM now dynamically maps the node-objects with machines if `Status.Node` is not set.

@hardikdr
Improve machine creation and deletion flow by verifying the VMs befor…
485ea93 
…e actually creating or deleting the machine.
@hardikdr hardikdr requested review from ggaurav10 and a team as code owners March 19, 2020 08:43
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 19, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 19, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@hardikdr hardikdr added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 22, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 22, 2020
prashanth26
prashanth26 reviewed Mar 26, 2020
View reviewed changes
pkg/controller/machine.go Show resolved Hide resolved
pkg/controller/machine.go Outdated Show resolved Hide resolved
pkg/controller/machine.go Show resolved Hide resolved
pkg/controller/machine.go Show resolved Hide resolved
ggaurav10
ggaurav10 suggested changes Mar 26, 2020
View reviewed changes
pkg/controller/machine.go Show resolved Hide resolved
pkg/controller/machine.go Show resolved Hide resolved
pkg/controller/machine.go Show resolved Hide resolved
pkg/controller/machine.go Outdated Show resolved Hide resolved
pkg/controller/machine.go Outdated Show resolved Hide resolved
pkg/controller/machine.go Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020
@hardikdr @prashanth26
Update pkg/controller/machine.go
b8480be 
Co-Authored-By: Prashanth <prashanth@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020
@prashanth26 prashanth26 merged commit 457025e into gardener:master Mar 27, 2020
@hardikdr hardikdr mentioned this pull request Mar 27, 2020
Closed
@hardikdr hardikdr mentioned this pull request Apr 14, 2020
Merged
@hardikdr hardikdr mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggaurav10 ggaurav10 ggaurav10 approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore ACID properties on MCM
6 participants
@hardikdr @ggaurav10 @prashanth26 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3