Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait also for CSI PVs during serial eviction #509

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Wait also for CSI PVs during serial eviction #509

merged 1 commit into from
Sep 14, 2020

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Sep 13, 2020 •
edited by prashanth26

What this PR does / why we need it:
Wait also for CSI PVs during serial eviction.

/kind bug

Which issue(s) this PR fixes:
Fixes #508

Release note:

Bugfix: Consider CSI PersistentVolumes during the eviction of Pods with PersistentVolumes.

@ialidzhikov
Wait also for CSI PVs during serial eviction
6eb18ff 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested review from ggaurav10 and a team as code owners September 13, 2020 17:06
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 13, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 13, 2020
prashanth26
prashanth26 approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the fix. Appreciate the tests as well 💯 .

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 13, 2020
hardikdr
hardikdr approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good.

@hardikdr hardikdr merged commit 9874f8f into gardener:master Sep 14, 2020
@hardikdr
Copy link
Member

We'll need to propagate this change to the vSphere-provider as well.
cc @MartinWeindel

@MartinWeindel MartinWeindel mentioned this pull request Sep 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 ggaurav10 approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

machine-controller-manager is not waiting for detach of CSI PVs
7 participants
@ialidzhikov @hardikdr @ggaurav10 @prashanth26 @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot