Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerGroup option for Openstack MachineClass #511

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Sep 14, 2020

What this PR does / why we need it:
Adds an extra optional field for specifying the ServerGroup in a machineClass. The PR is a preparation for managing workergroup anti-affinity via ServerGroups. ServerGroup creation and management will be implemented on the Openstack-extension side.

Which issue(s) this PR fixes:
Fixes #30

Special notes for your reviewer:

Release note:

Add support for ServerGroups in the Openstack driver. VMs can now be created in the ServerGroup specified in the respective `MachineClass`.

@kon-angelo kon-angelo requested review from ggaurav10 and a team as code owners September 14, 2020 15:30
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 14, 2020
@kon-angelo
Copy link
Contributor Author

@dkistner

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2020
@dkistner
Copy link
Member

Could you please add a release note?

Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 14, 2020
@hardikdr
Copy link
Member

/invite @zuzzas

@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Sep 15, 2020
@gardener gardener deleted a comment from gardener-robot Sep 15, 2020
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 15, 2020
@hardikdr hardikdr merged commit b144479 into gardener:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenStack Hypervisor Anti-Affinity
8 participants