Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deletion of machines where modify instance fails on deletion #515

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Allow deletion of machines where modify instance fails on deletion #515

merged 1 commit into from
Oct 1, 2020

Conversation

prashanth26
Copy link
Contributor

@prashanth26 prashanth26 commented Sep 23, 2020 •
edited

What this PR does / why we need it:
Allows deletion of machines even on modify instance call failure

Which issue(s) this PR fixes:
Fixes #514

Special notes for your reviewer:

Release note:

AWS: Allows deletion of machines even on modify instance call failure

@prashanth26 prashanth26 requested review from ggaurav10 and a team as code owners September 23, 2020 06:33
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2020
@prashanth26 prashanth26 force-pushed the bugfix/continue-deletion-on-error branch from 78f3bdd to 29d0c89 Compare September 23, 2020 07:24
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2020
@prashanth26
Copy link
Contributor Author

/needs review

@gardener-robot gardener-robot added the needs/review Needs review label Sep 28, 2020
@prashanth26 prashanth26 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 1, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 1, 2020
@hardikdr hardikdr merged commit be57a20 into gardener:master Oct 1, 2020
@prashanth26 prashanth26 deleted the bugfix/continue-deletion-on-error branch May 2, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow deletion of VM when AMI is not found in AWS.
6 participants
@prashanth26 @hardikdr @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot