Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump aws sdk version to v1.23.13 #580

Merged
merged 1 commit into from
Dec 3, 2020
Merged

bump aws sdk version to v1.23.13 #580

merged 1 commit into from
Dec 3, 2020

Conversation

zjj2wry
Copy link
Contributor

@zjj2wry zjj2wry commented Dec 3, 2020 •
edited by hardikdr

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
bum sdk version to v1.23.13, it will support AWS Web Identity provider
https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html
https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html

Release note:

Bumped AWS SDK version to v1.23.13

@zjj2wry zjj2wry requested review from ggaurav10 and a team as code owners December 3, 2020 07:58
@gardener-robot gardener-robot added the needs/review Needs review label Dec 3, 2020
@gardener-robot
Copy link

@zjj2wry Thank you for your contribution.

@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Dec 3, 2020
@gardener-robot-ci-2
Copy link
Contributor

Thank you @zjj2wry for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@hardikdr hardikdr added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 3, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 3, 2020
@prashanth26
Copy link
Contributor

Hi @zjj2wry ,

Thank you for your contribution. We appreciate it.

Just so you know we are migrating all the providers into out-of-tree providers. Kindly send in your future PRs on the OOT branch. I have left a note with the same on the Readme.md file here - https://github.com/gardener/machine-controller-manager/blob/master/README.md.

prashanth26
prashanth26 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 3, 2020
@prashanth26 prashanth26 merged commit e27b078 into gardener:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zjj2wry @gardener-robot @gardener-robot-ci-2 @prashanth26 @hardikdr @gardener-robot-ci-1