Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test framework now fetches secrets from the correct (control) APIServer while running tests #617

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Test framework now fetches secrets from the correct (control) APIServer while running tests #617

merged 1 commit into from
Jun 2, 2021

Conversation

himanshu-kun
Copy link
Contributor

@himanshu-kun himanshu-kun commented Jun 1, 2021 •
edited by prashanth26

What this PR does / why we need it:

  • test framework for package controller modified
  • secrets now part of controlCoreObjects
  • controlCoreClient used for fetching secrets

Which issue(s) this PR fixes:
Fixes # 616

Special notes for your reviewer:

Release note:

Test framework now fetches secrets from the correct (control) APIServer while running tests.

@himanshu-kun himanshu-kun requested a review from a team as a code owner June 1, 2021 17:21
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 1, 2021
@gardener-robot-ci-2
Copy link
Contributor

Thank you @himanshu-kun for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@AxiomSamarth
Copy link
Collaborator

reviewed/ok-to-test

prashanth26
prashanth26 approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

Thanks for this change.
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 2, 2021
@prashanth26
Copy link
Contributor

/ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 2, 2021
@prashanth26 prashanth26 merged commit b579754 into gardener:master Jun 2, 2021
@himanshu-kun himanshu-kun deleted the enhancement/secretAsControlCoreObject branch June 6, 2021 15:10
@prashanth26
Copy link
Contributor

prashanth26 commented Jun 14, 2021 •
edited

/title Test framework now fetches secrets from the correct (control) APIServer while running tests

@gardener-robot
Copy link

@prashanth26 Command /titile is not known.

@gardener-robot gardener-robot changed the title Secrets moved to controlCoreObjects in tests Test framework now fetches secrets from the correct (control) APIServer while running tests Jun 14, 2021
@prashanth26 prashanth26 mentioned this pull request Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxiomSamarth AxiomSamarth AxiomSamarth approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@himanshu-kun @gardener-robot-ci-2 @AxiomSamarth @prashanth26 @gardener-robot @gardener-robot-ci-1