Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Integration tests #618

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Add Integration tests #618

merged 2 commits into from
Jul 20, 2021

Conversation

rkjakeer
Copy link
Contributor

@rkjakeer rkjakeer commented Jun 2, 2021 •
edited
Loading

What this PR does / why we need it:
This PR adds a set of common Integration test cases as a framework for all machine-controller-manager-provider-{provider-name} repositories.

Which issue(s) this PR fixes:
Fixes #216

Special notes for your reviewer:

Release note:

NONE

@rkjakeer rkjakeer requested a review from a team as a code owner June 2, 2021 18:52
@CLAassistant
Copy link

CLAassistant commented Jun 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot
Copy link

@rkjakeer Thank you for your contribution.

@gardener-robot gardener-robot added the needs/review Needs review label Jun 2, 2021
@gardener-robot-ci-2
Copy link
Contributor

Thank you @rkjakeer for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 2, 2021
@prashanth26
Copy link
Contributor

Hi @rkjakeer ,

Thanks for this PR. Might need a couple of days to have a look.
/assign
/cla

@gardener-robot
Copy link

@prashanth26 I reached out successfully to the cla-assistant to recheck this pull request.

@prashanth26
Copy link
Contributor

Also, I think your commits are coming from different user names. Please try to amend the commits to make them originate from a single ID. Also do sign the CLA as requested by the bot.

@gardener-robot gardener-robot added lifecycle/stale Nobody worked on this for 6 months (will further age) needs/rebase Needs git rebase labels Jun 10, 2021
@gardener-robot
Copy link

@rkjakeer You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jun 14, 2021
@prashanth26
Copy link
Contributor

No change required for IT - #623.

@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/rebase Needs git rebase and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 17, 2021
@gardener-robot
Copy link

@rkjakeer You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jun 24, 2021
AxiomSamarth
AxiomSamarth suggested changes Jun 29, 2021
View reviewed changes
pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved
pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jun 29, 2021
@AxiomSamarth
Copy link
Collaborator

AxiomSamarth commented Jun 29, 2021 •
edited
Loading

Hi @rkjakeer,

Thank you for this amazing PR! I absolutely loved the simplicity of usage. Please find two review comments from my side from my first execution of this suite. And maybe, you can combine the related, relevant code changes into a fewer commits

Summary:

Ran 10 of 10 Specs in 459.012 seconds
FAIL! -- 9 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestController (459.02s)
FAIL

prashanth26
prashanth26 reviewed Jul 1, 2021
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rkjakeer @toniajuliejackson ,

Apologies for the delay in reviewing. The tests look really good. We really appreciate the changes. I just have a few minor comments. Looks good to me otherwise.

cc: @amshuman-kr @AxiomSamarth

kubernetes/deployment/out-of-tree/deployment.yaml Outdated Show resolved Hide resolved
pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved
pkg/test/integration/common/framework.go Show resolved Hide resolved
pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved
pkg/test/integration/common/helpers/cluster.go Outdated Show resolved Hide resolved
pkg/test/integration/common/helpers/cluster.go Outdated Show resolved Hide resolved
pkg/test/integration/common/helpers/handling_files.go Outdated Show resolved Hide resolved
pkg/test/integration/common/helpers/handling_files.go Outdated Show resolved Hide resolved
pkg/test/integration/common/helpers/rbac.go Outdated Show resolved Hide resolved
@prashanth26
Copy link
Contributor

Also lastly it would be great to split the PR into two commits before the final merge. One with your actual changes and the other with vendoring changes.
/squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Jul 1, 2021
@prashanth26 prashanth26 removed the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label Jul 1, 2021
@rkjakeer
Copy link
Contributor Author

rkjakeer commented Jul 2, 2021

Hi @rkjakeer @toniajuliejackson ,

Apologies for the delay in reviewing. The tests look really good. We really appreciate the changes. I just have a few minor comments. Looks good to me otherwise.

Hi @prashanth26,

No problem. I have made the changes as suggested.
Thanks a lot for the feedback and the code review.

@rkjakeer rkjakeer force-pushed the master branch 4 times, most recently from 24d6f52 to 41b35e8 Compare July 16, 2021 12:38
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jul 16, 2021
@gardener-robot
Copy link

@rkjakeer You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jul 16, 2021
prashanth26
prashanth26 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.
/lgtm overall, @AxiomSamarth and @himanshu-kun seem to have tested this. We might need minor refactoring in the future to accommodate this into your CI pipelines.

docs/development/cp_support_new.md Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging needs/second-opinion Needs second review by someone else and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 19, 2021
prashanth26
prashanth26 reviewed Jul 19, 2021
View reviewed changes
go.mod Show resolved Hide resolved
@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Jul 19, 2021
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jul 19, 2021
rkjakeer and others added 2 commits July 19, 2021 15:04
@rkjakeer @toniajuliejackson
Add integration test framework
da6ca2c 
* Add integrationtest directory

* Use rti interface for integration testing

* update makefile

Co-Authored-By: Tonia Jackson <tonia.julie@gmail.com>
@rkjakeer
perform revendor
5a199a4
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jul 19, 2021
@AxiomSamarth
Copy link
Collaborator

@prashanth26 I tested this suite against AWS and Azure clusters. Test Suite succeeded for both. This could be merged now.

@prashanth26
Copy link
Contributor

@AxiomSamarth - Thank you for this. We can merge once @rkjakeer confirms.

@prashanth26 prashanth26 merged commit c02bcdf into gardener:master Jul 20, 2021
@prashanth26 prashanth26 mentioned this pull request Jul 21, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

@AxiomSamarth AxiomSamarth AxiomSamarth approved these changes

Assignees

@prashanth26 prashanth26

Labels
merge/squash Should be merged via 'Squash and merge' needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test framework for MCM
6 participants
@rkjakeer @CLAassistant @gardener-robot @gardener-robot-ci-2 @prashanth26 @AxiomSamarth