Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodeName and providerID column while listing machines(s) #746

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Add nodeName and providerID column while listing machines(s) #746

merged 2 commits into from
Sep 29, 2022

Conversation

rishabh-11
Copy link
Contributor

@rishabh-11 rishabh-11 commented Sep 21, 2022 •
edited
Loading

What this PR does / why we need it:
WIth this PR, when one runs the kubectl get machines command,Node name will be displayed as a column. If the -owide option is used then ProviderID will also be displayed as a column. The output will be as follows:
Screenshot 2022-09-21 at 1 58 33 PM

Screenshot 2022-09-29 at 3 26 25 PM

Which issue(s) this PR fixes:
Fixes #737

Special notes for your reviewer:

Release note:

Using `kubectl get machines` will display `Node` of the corresponding machine as a column. If `-owide` flag is used then the corresponding `ProviderID` will also be displayed.

@rishabh-11 rishabh-11 requested a review from a team as a code owner September 21, 2022 08:36
@gardener-robot
Copy link

@rishabh-11 Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 21, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 21, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2022
@himanshu-kun himanshu-kun changed the title Display providerID as a column name for machines Add nodeName and providerID column while listing machines(s) Sep 29, 2022
himanshu-kun
himanshu-kun approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for the changes!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 29, 2022
@himanshu-kun himanshu-kun merged commit 756e0b1 into gardener:master Sep 29, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 29, 2022
@rishabh-11 rishabh-11 deleted the providerID-as-column-name branch September 29, 2022 10:21
@ashwani2k ashwani2k mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print node and instance details when printing machines on console.
5 participants
@rishabh-11 @gardener-robot @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2