Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rel-v0.49] Automated cherry pick of #833: include unavailable replicas in mcd status update check #834

Merged
merged 1 commit into from
Jun 21, 2023
Merged

[rel-v0.49] Automated cherry pick of #833: include unavailable replicas in mcd status update check #834

merged 1 commit into from
Jun 21, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jun 21, 2023 •
edited

/kind bug

Cherry pick of #833 on rel-v0.49.

#833: include unavailable replicas in mcd status update check

Release note:

Included `UnavailableReplicas` in determining if a machine deployment status update is needed

@ialidzhikov ialidzhikov requested a review from a team as a code owner June 21, 2023 12:33
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 21, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 21, 2023
@ialidzhikov ialidzhikov changed the title Automated cherry pick of #833: include unavailable replicas in mcd status update check [rel-v0.49] Automated cherry pick of #833: include unavailable replicas in mcd status update check Jun 21, 2023
rishabh-11
rishabh-11 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@rishabh-11 rishabh-11 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 21, 2023
@rishabh-11 rishabh-11 self-assigned this Jun 21, 2023
@rishabh-11 rishabh-11 merged commit 322da21 into gardener:rel-v0.49 Jun 21, 2023
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@rishabh-11 rishabh-11

Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ialidzhikov @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot