Support checking GKE version schema #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lookuptable Thank you for your contribution. |
gardener-robot
added
the
size/xs
|
Thank you @lookuptable for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
|
sssash18
added
reviewed/ok-to-test
|
/lgtm |
gardener-robot
added
reviewed/lgtm
sssash18
approved these changes
Dec 19, 2023
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The version format of GKE clusters is $K8S_VERSION-gke.$INTERNAL_NUMBER (e.g., 1.27.9-gke.300). This format is not fully compliant to the SEMVER spec and causes this library to mistakenly recognize, for example, a 1.27.9-gke.300 cluster to be older than 1.21. This is a known issue (e.g., helm/helm#3810), and this change updates the version constraint to properly support GKE versions.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note:
NONE