Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nodes without hostname #66

Merged
merged 1 commit into from
May 22, 2024
Merged

Allow nodes without hostname #66

merged 1 commit into from
May 22, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Building the cluster config was assuming that nodes always have both InternalIP and Hostname addresses in the Node status. The assumption has been dropped to ignore nodes without InternalIP address. If Hostname is not set, the node name is used as fallback. The Hostname is only used for display purposes anyway.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Allow nodes without hostname

@MartinWeindel MartinWeindel requested a review from a team as a code owner May 21, 2024 10:11
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 21, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 21, 2024
ScheererJ
ScheererJ approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 22, 2024
@MartinWeindel MartinWeindel merged commit 1d1d9fa into main May 22, 2024
6 checks passed
@MartinWeindel MartinWeindel deleted the allow-nodes-without-hostname branch May 22, 2024 09:12
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-3 @gardener-robot