Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allowPrivilegedContainers to flavors #287

Merged
merged 3 commits into from
May 29, 2020

Conversation

dguendisch
Copy link
Member

What this PR does / why we need it:
Adds allowPrivilegedContainers as an additional option in the flavor configuration. Gardener shoots default to true is this option is not set, hence you can use it to disable privileged containers for certain tests or have your tests run against both: shoots with allowPrivilegedContainers="true" and shoots with allowPrivilegedContainers="false"

Release note:

`allowPrivilegedContainers` can now be customized in the flavor configuration.

@dguendisch dguendisch requested a review from schrodit May 28, 2020 12:28
@dguendisch dguendisch requested a review from a team as a code owner May 28, 2020 12:28
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2020
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we maybe want to add it as metadata field so that we can see the differences in the execution?
And we could also think of adding it to our dimensions to reflect it in the dashboard/alerting?
WDYT?

https://github.com/gardener/test-infra/blob/master/pkg/testmachinery/metadata/types.go#L18

pkg/common/types_shootflavor.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2020
@dguendisch
Copy link
Member Author

Regarding metadata, I though it would be enough to distinguish via flavor description, but you are right, a dedicated metadata is better, I'll add that, thanks for the suggestion.

Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor nit rest is lgtm

pkg/shootflavors/extendedflavors_test.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@dguendisch
Copy link
Member Author

added metadata support, hope I didn't miss some places, ptal

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to read the metadta from the testrun here https://github.com/gardener/test-infra/blob/master/pkg/testmachinery/metadata/metadata.go#L57

How about adding it also here https://github.com/gardener/test-infra/blob/master/pkg/testmachinery/metadata/metadata.go#L41 so that it will also be displayed in the tm dashboard and the slack notifications?

pkg/testmachinery/metadata/types.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@dguendisch
Copy link
Member Author

dguendisch commented May 29, 2020

we also need to read the metadta from the testrun here https://github.com/gardener/test-infra/blob/master/pkg/testmachinery/metadata/metadata.go#L57

Added.

How about adding it also here https://github.com/gardener/test-infra/blob/master/pkg/testmachinery/metadata/metadata.go#L41 so that it will also be displayed in the tm dashboard and the slack notifications?

I actually envisioned to put it in the description of the flavor configuration, but sure, putting it directly in the code is more consistent in the end, so added it.

PTAL

Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor nit. rest is lgtm

pkg/testmachinery/metadata/metadata.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2020
@dguendisch dguendisch merged commit b95edbe into master May 29, 2020
@dguendisch dguendisch deleted the allowPrivilegedContainers branch May 29, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants