Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaylorMade update #780

Merged
merged 1 commit into from
May 11, 2023
Merged

TaylorMade update #780

merged 1 commit into from
May 11, 2023

Conversation

angstsmurf
Copy link
Contributor

@angstsmurf angstsmurf commented May 8, 2023

EDIT: Now it should work.

Improved formatting of gameinfo.c

Added some minimal documentation of the extra commands.

Extra commands like TRANSCRIPT OFF was broken in games that defined OFF in their internal dictionary (and TRANSCRIPT ON if they defined ON, and so on.)

Fixed some problems with undo. It would skip some turns and occasionally break. It is no longer possible to undo into the Kayleth "intro location".

Renamed buffer[] array to not shadow local LibSpectrum variables.

One animation in Kayleth (the firing android) would not show at all. Other animations are closer to how they looked on the original hardware, and the animation code is a little more readable.

Energy display in Rebel Planet said 0 where it should say 00.

Multiple waiting now matches the originals. It actually waits one extra turn, but won't print a message for the last one.

Gives the same error messages as the originals: One of three depending on whether it understood none of the input words ("I can’t compute that... sorry!"), only understood a noun but no verb ("Please try varying that verb"), or found a verb but no matching command ("That’s not possible.")

@angstsmurf angstsmurf changed the title TaylorMade update DO NOT MERG: TaylorMade update May 9, 2023
@angstsmurf angstsmurf changed the title DO NOT MERG: TaylorMade update DO NOT MERGE: TaylorMade update May 9, 2023
@angstsmurf angstsmurf changed the title DO NOT MERGE: TaylorMade update TaylorMade update May 9, 2023
@angstsmurf angstsmurf force-pushed the taylor-update branch 3 times, most recently from 7bf32dc to 4129a86 Compare May 9, 2023 23:22
Update docs a bit, adding some minimal documentation of the added
commands.

Improved formatting of gameinfo.c

Extra commands like TRANSCRIPT OFF was broken in games that defined OFF
in their internal dictionary (and TRANSCRIPT ON if they defined ON,
and so on.)

Fix some problems with undo.

Rename buffer[] array to not shadow local libspectrum variables.

One animation in Kayleth (the firing android) would not show.
The assembly line in room 2 is now smoother.

Energy display in Rebel Planet said 0 where it should say 00.

Multiple waiting now matches original. It actually waits one extra
turn, but won't print a message for the last one.
@cspiegel cspiegel merged commit e2f447c into garglk:master May 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants