🐠️ babel@7 📦️ upgrades #31

JeromeFitz · 2018-12-28T01:23:04Z

🐠️ babel@7

⬆️ Upgrade from babel@6

📦️ package(-lock).json

⬆️ upgrades
🔥️ removal of unused (or handled by next)

JeromeFitz · 2018-12-28T01:28:43Z

Tried to do this as 1:1 as possible to keep the PR size down. (Some other enhancements I have may be more preference rather than function and would want to get more input on.)

Tests all pass and build is working. This may be a decent first step for prep with #4.

 PASS  src/meta/__tests__/buildTags.spec.jsx
  ✓ renders correctly (35ms)
  ✓ returns full array for default seo object (55ms)
  ✓ correctly sets noindex, nofollow (9ms)
  ✓ displays title with titleTemplate integrated (13ms)
  ✓ Article SEO renders correctly (8ms)
  ✓ Check article og type meta (10ms)
  ✓ Book SEO renders correctly (12ms)
  ✓ Check book og type meta (11ms)
  ✓ Profile SEO renders correctly (6ms)
  ✓ Check profile og type meta (6ms)

Test Suites: 1 passed, 1 total
Tests:       10 passed, 10 total
Snapshots:   4 passed, 4 total
Time:        2.094s

JeromeFitz · 2018-12-28T15:32:38Z

😅 Whew.

garmeeh · 2018-12-28T20:20:37Z

Hey @JeromeFitz thanks very much for the PR 💪

I haven't had a chance just yet to have a look, but hope to get it over the weekend.

JeromeFitz · 2018-12-28T20:30:11Z

Very cool.

As a heads up, in testing some stuff locally I was inadvertently using the test:e2e and not test:e2e:dev. 😬

Sorry about that. I look to have blown up the spot in the free tier for December. 😞

garmeeh

Hey @JeromeFitz, just testing this out and everything is looking good. Just have some questions.

taskfile.js

package.json

🐠️ babel@7 - ⬆️ Upgrade from babel@6 ✨️ taskr - Instead of babel/cli 📦️ package.json - ⬆️ upgrades TODO: Verify Major Version Upgrades of: - eslint-plugin-jest@22.1.2 - react-testing-library@5.4.2 - regenerator-runtime@0.13.1

⬆️ - eslint-plugin-jest@22.1.2 - react-testing-library@5.4.2 - regenerator-runtime@0.13.1 📈️ Test Suites: 1 passed, 1 total Tests: 10 passed, 10 total Snapshots: 4 passed, 4 total

This should get travis working.

Cypress is not keen on babel.config.js (babel@7) just yet.

We probably don't want these in the repo.

- Prefer @babel/cli over taskr - Move __tests__ as they are not being ignored

JeromeFitz · 2019-01-06T17:50:15Z

Thanks for looking into this @garmeeh !

Removed taskr and went back to using babel's cli like we had before.

One caveat, I couldn't get the .spec.js files not to compile. 😬 So I moved them to the root for now. If we want to keep the tests files together, I can spend a little more time on it.

`next@7.0.2-canary.35` was the implementation - Dedupe only items with unique key: [5800](vercel/next.js#5800) In upgrading all the packges in this PR, some versions were not working (not sure why). I've tested with the latest `canary` from `next` and everything is passing.

🐠️ next/babel Since we rely on `next` they handle presets through `next/babel` and we can modify if we want. (skeleton left in place) 🔥️ unused packages These are all handled by `next`: - @babel/runtime (`regenerator-runtime`) - @babel/preset-env - @babel/preset-react - babel-core - babel-loader And not used by `next-seo` I believe. `flatten` should have been removed via `taskr` commit

garmeeh

Looking good 💪, just two small comments. Once they are addressed I am happy to merge 😄

If the suggested change works for excluding the tests from compiling, let's move the tests back.

package.json

babel.config.js

📦️ #.#.# = Specific Versions - Was having a terrible time with `npm install` and `^` in package.json. - Is it cool to do this for now? - - I didn't want to just move to `yarn` because I was running into npm troubles 🐠️ babel Added: - babel-core@7.0.0-bridge.0 => needed until jest moves to babel@7 - babel-minify Presets: - Removed the empty objects 🃏️ jest - Putting in the blank values was breaking the tests 🔥️ @babel/plugin-proposal-object-rest-spread 🚚️ test - Moved __tests__ back - Have an extra `rimraf` removing them from the `build`.

JeromeFitz · 2019-01-08T22:28:10Z

Can't seem to dismiss, let me know if you'd like anything else. 👍

Added babel-minify and re-ran the tests and the e2e:test:dev. Everything is looking good.

Should reduce the size a bit: packagephobia?next-seo

garmeeh

💪 Nice one!

JeromeFitz · 2019-01-09T15:08:33Z

Word up. Thanks for going over everything! 💯️

JeromeFitz mentioned this pull request Dec 28, 2018

code-splitting #4

Closed

JeromeFitz force-pushed the babel@7 branch from 88b18c2 to 5022567 Compare December 29, 2018 17:30

garmeeh reviewed Jan 3, 2019

View reviewed changes

taskfile.js Outdated Show resolved Hide resolved

taskfile.js Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

JeromeFitz added 6 commits January 6, 2019 12:16

⬆️ eslint-plugin-jest, react-testing...

b2942a7

⬆️ - eslint-plugin-jest@22.1.2 - react-testing-library@5.4.2 - regenerator-runtime@0.13.1 📈️ Test Suites: 1 passed, 1 total Tests: 10 passed, 10 total Snapshots: 4 passed, 4 total

💚️ update build script, add build:watch

94524ce

This should get travis working.

💚️ e2e must currently use: .babelrc.js

26b6c98

Cypress is not keen on babel.config.js (babel@7) just yet.

🙈️ e2e/cypress/videos

0ef1d9c

We probably don't want these in the repo.

🐠️ @babel/cli 🔥️ taskr 🚚️ __tests__

77e79f3

- Prefer @babel/cli over taskr - Move __tests__ as they are not being ignored

JeromeFitz force-pushed the babel@7 branch from 5022567 to 77e79f3 Compare January 6, 2019 17:45

JeromeFitz added 2 commits January 6, 2019 13:02

JeromeFitz changed the title ~~🐠️ babel@7 ✨️ taskr 📦️ upgrades~~ 🐠️ babel@7 📦️ upgrades Jan 6, 2019

garmeeh requested changes Jan 8, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

babel.config.js Show resolved Hide resolved

garmeeh approved these changes Jan 9, 2019

View reviewed changes

garmeeh merged commit d931dad into garmeeh:master Jan 9, 2019

JeromeFitz deleted the babel@7 branch January 9, 2019 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐠️ babel@7 📦️ upgrades #31

🐠️ babel@7 📦️ upgrades #31

JeromeFitz commented Dec 28, 2018 •

edited

Loading

JeromeFitz commented Dec 28, 2018

JeromeFitz commented Dec 28, 2018

garmeeh commented Dec 28, 2018

JeromeFitz commented Dec 28, 2018

garmeeh left a comment

JeromeFitz commented Jan 6, 2019

garmeeh left a comment

JeromeFitz commented Jan 8, 2019 •

edited

Loading

garmeeh left a comment

JeromeFitz commented Jan 9, 2019

🐠️ babel@7 📦️ upgrades #31

🐠️ babel@7 📦️ upgrades #31

Conversation

JeromeFitz commented Dec 28, 2018 • edited Loading

JeromeFitz commented Dec 28, 2018

JeromeFitz commented Dec 28, 2018

garmeeh commented Dec 28, 2018

JeromeFitz commented Dec 28, 2018

garmeeh left a comment

Choose a reason for hiding this comment

JeromeFitz commented Jan 6, 2019

garmeeh left a comment

Choose a reason for hiding this comment

JeromeFitz commented Jan 8, 2019 • edited Loading

garmeeh left a comment

Choose a reason for hiding this comment

JeromeFitz commented Jan 9, 2019

JeromeFitz commented Dec 28, 2018 •

edited

Loading

JeromeFitz commented Jan 8, 2019 •

edited

Loading