Next 8 dependencies #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like it wants the updated package-lock - but running into some errors in e2e when attempting to install dependencies with npm instead of yarn. |
|
I just removed the |
|
😢 That didn't work either. Just fixed it on master there. That resulted in the conflicts so to save you the hassle of solving those I pushed the changes you had to master and released a patch. So it's available now @1.10.1. Thanks for the PR either way and sorry about the hassle 😃 I will add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next v8.0.0 was officially released so this will get rid of the peer dependency warning when using next-seo in a project on the new version. I ran tests with no issues. Also I can suggest only having one of yarn.lock or package-lock.json in root directory. i.e. delete/gitignore the package-lock.json and only support yarn in this project for managing dependencies or vice-versa.