Typo in ml_gtk_text_buffer_get_iter_at_line_index #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Indeed, this is a no-brainer. Thanks. |
|
@garrigue: what are your plans/policy for releases. Is there some chance that a new release including the fix is done before Coq releases its version 8.20, planned end of June? |
|
I can do that the week of June 10th. Now that OCaml 5.2 is released is a good timing for me too. |
|
That would be great! Thanks. |
garrigue
added a commit
to garrigue/opam-repository
that referenced
this pull request
Jun 10, 2024
CHANGES: 2024.06.10 [Jacques] * Prepare for release * Fix typos in README.md (garrigue/lablgtk#182) [Sylvain Chiron] 2024.05.20 [Jacques] * Typo in ml_gtk_text_buffer_get_iter_at_line_index. (garrigue/lablgtk#181) [Hugo Herbelin] 2024.05.14 [Jacques] * Support windows sockets in Glib.IO.channel_of_descr (garrigue/lablgtk#176) [with Michael Soegtrop] 2024.03.24 [Jacques] * fix pointer incompatibility in ml_gtk_style_context_list_classes (garrigue/lablgtk#178)
|
@herbelin I have made a release last week. The opam package (ocaml/opam-repository#26047) is in the pipeline, but I have no idea how long it will take. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there seems to be a typo in the definition of
ml_gtk_text_buffer_get_iter_at_line_indexas its code refers togtk_text_buffer_get_iter_at_line_offset(like inml_gtk_text_buffer_get_iter_at_line_offset) while I guessgtk_text_buffer_get_iter_at_line_indexis instead expected. I did not test the change, but we observed an utf8 issue in coqide which might be caused by this. Best, Hugo