Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in cx function #34

Closed
olee opened this issue Nov 5, 2021 · 2 comments
Closed

Bug in cx function #34

olee opened this issue Nov 5, 2021 · 2 comments

Comments

@olee
Copy link

olee commented Nov 5, 2021

If I'm not mistaken, in this line, the code should not be

.map(classNameOrCSSObject =>
    typeof classNameOrCSSObject === "string"
        ? className
        : css(classNameOrCSSObject),
)

but instead

.map(classNameOrCSSObject =>
    typeof classNameOrCSSObject === "string"
        ? classNameOrCSSObject
        : css(classNameOrCSSObject),
)
@garronej
Copy link
Owner

garronej commented Nov 5, 2021

Hi @olee,
Glad to see you back.
Yes you are right! Good catch.
Do you want to submit a PR or do I fix it now?

@olee
Copy link
Author

olee commented Nov 5, 2021

I think in this case it's easier you just fix it quickly 😄
Otherwise I would have directly created a PR but I don't really want to bother right now :-P

garronej added a commit that referenced this issue Nov 5, 2021
@garronej garronej closed this as completed Nov 5, 2021
gitbook-com bot pushed a commit that referenced this issue Jan 26, 2022
gitbook-com bot pushed a commit that referenced this issue Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants