Add support of merging classes in withStyles #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
we just migrated to
tss-react
in MUIv4 based project and we found a small difference in howwithStyles
work in MUI and here.The difference is in maybe a special case. Here's a small example:
The problem is that
StyledInput
won't getred
color as one would expect. The reason is thatwithStyles
currently doesn't mergeclasses
passed inprops
of the wrapping component.I tried to add it by using
mergeClasses
function where I noticed another small issue. The problem is whenclasses
doesn't contain all the keys; then the key present onclassesOv
would be missing in the output classes object.