adding more tests

cpan-testers · Apr 23, 2016 · 4b11bad · 4b11bad
1 parent 331647d
commit 4b11bad
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/CPAN/Testers/Common/Client/Config.pm b/lib/CPAN/Testers/Common/Client/Config.pm
@@ -424,7 +424,7 @@ sub _config_data {
 
 sub _config_data_for {
     my ($self, $type, $grade) = @_;
-    my %spec = $self->config_spec;
+    my %spec = $self->_config_spec;
     my $data = exists $self->{_config}{$type} ? $self->{_config}{$type} : q();
 
     my $dispatch = $spec{$type}{validate}->(

diff --git a/t/02-config.t b/t/02-config.t
@@ -46,7 +46,7 @@ is_deeply(
 my $td = tempdir(File::Spec->catdir('t', 'cf XXXX'), CLEANUP => 1);
 to_file(File::Spec->catfile($td, 'config.ini'), <<'EOF');
 edit_report=default:ask/no pass/na:no
-email_from=bogus@cpan.org
+email_from=Some User (SOMEUSER) <bogus@cpan.org>
 send_report=default:ask/yes pass/na:yes
 transport=Metabase uri https://metabase.cpantesters.org/api/v1/ id_file metabase_id.json
 EOF
@@ -84,6 +84,14 @@ for my $method (qw(myprompt mywarn myprint read)) {
     is $@, '', $method;
 }
 
+is(
+    $config->email_from,
+    'Some User (SOMEUSER) <bogus@cpan.org>',
+    'got the right email_from'
+);
+
+is $config->transport_name, 'Metabase', 'found right transport name';
+
 my %args = @{ $config->transport_args };
 is_deeply \%args, {
         'uri',