Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "Nested quantifiers in regex" error on perl 5.8.x #12

Merged
merged 1 commit into from Apr 19, 2018
Merged

fix "Nested quantifiers in regex" error on perl 5.8.x #12

merged 1 commit into from Apr 19, 2018

Conversation

karenetheridge
Copy link
Contributor

closes issue #11

All tests pass, but please confirm that I did not change the intention of the regex!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.894% when pulling 4eceadd on karenetheridge:topic/nested_quantifiers into 21e6d31 on garu:master.

@karenetheridge
Copy link
Contributor Author

waves from the 2017 Toolchain Summit

@Grinnz
Copy link

Grinnz commented May 23, 2017

To preserve the possessive quantifier, (?:\\?+.) could be changed to (?:(?>\\?).)

@karenetheridge
Copy link
Contributor Author

commit amended as per Grinnz's suggestion.

@garu garu merged commit 2733ef0 into cpan-testers:master Apr 19, 2018
@karenetheridge karenetheridge deleted the topic/nested_quantifiers branch April 19, 2018 17:41
@karenetheridge
Copy link
Contributor Author

♥︎♥︎♥︎👯💃🏼👯‍♂️🕺💃🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karenetheridge @coveralls @Grinnz @garu