Merge pull request #88 from bessarabov/fixing__is_number

'-' is a string, not a number
garu · May 7, 2016 · a065ac9 · a065ac9
2 parents 6735476 + c30d6f0
commit a065ac9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/Data/Printer.pm b/lib/Data/Printer.pm
@@ -366,7 +366,7 @@ sub _is_number {
         -?          # number can start with minus, but can't start with plus
                     # is scalar starts with plus it is not number
 
-        [0-9-]+     # then there should be some numbers
+        [0-9]+      # then there should be some numbers
 
         ( \. [0-9]+ )?      # there can be decimal part, which is optional
 

diff --git a/t/43-_is_number.t b/t/43-_is_number.t
@@ -43,6 +43,7 @@ my @strings = (
     '1_000',
     '123\n',
     "123\n",
+    '-',
 );
 
 foreach my $not_a_number (@strings) {