Add GraphQL instrumentation for tracing with OpenTelemetry #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruv-m-patel
requested review from
ryanvasselin,
normrider2001 and
ty-grubber
dhruv-m-patel
force-pushed
the
dhruv/add-graphql-instrumentation
branch
from
e665d7d
to
988fca3
Compare
ty-grubber
approved these changes
Jan 29, 2024
|
Gonna try this now after merging on tracker-web. I think I'll still need an update on gb-services to reflect this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reached at the stage where tracker-web with latest gb-services is fully functional on staging but is missing tracing for GraphQL tracing which was one of the motivations behind the upgrade.
Adding the required instrumentation with this change now.