Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade versions for actions/checkout and actions/setup-node #329

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

dhruv-m-patel
Copy link
Contributor

@dhruv-m-patel dhruv-m-patel commented Jan 27, 2024

The old actions/checkout and actions/setup-node workflows provided by GitHub which we use as of now shows warnings that node 16 actions are deprecated and we should upgrade to newer workflows.

Will version this once #328 is merged.

Window_and_12_21_0_·_gas-buddy_service_988fca3

Copy link

@ty-grubber ty-grubber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what the difference is b/w v3 and v4, so take this approval with a grain of salt. If the steps are still working fine then I trust this change should be fine.

@dhruv-m-patel
Copy link
Contributor Author

I don't really know what the difference is b/w v3 and v4, so take this approval with a grain of salt. If the steps are still working fine then I trust this change should be fine.

@ty-grubber thanks for your concern.

You can see the warning with the screenshot attached in the PR description above, and here is the latest CI run screenshot for the updated actions versions:

Window_and_ci__Upgrade_versions_for_actions_checkout_and_actions_setup-node_·_gas-buddy_service_5b8a8ff

The workflows are confirmed to be working with no warnings, and they are the latest versions so we should be good for a good amount of time using them.

@dhruv-m-patel dhruv-m-patel merged commit 44b5ce5 into main Jan 29, 2024
1 check passed
@dhruv-m-patel dhruv-m-patel deleted the dhruv/upgrade-actions branch January 29, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants