forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: PureScript in Signal Desktop #2
Open
gasi
wants to merge
108
commits into
development
Choose a base branch
from
purescript
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Compiler: `purescript` - Build tool: `pulp`
- `replaceUnicodeOrderOverridesSync`
This will allow us to use `Message` for our union type of the different message types, e.g. incoming, outgoing, verified-change, keychange, etc.
For some reason, some of our database records have timestamp that are `Long`s instead of `Number`.
Is either set in `size` or `length`.
- Use `Fn*` / `runFN*` uncurrying optimizations. - Pass data in last, i.e. phone number
Used for phone number formatting.
Workaround since our HTML now doesn’t include spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Message
,Conversation
, based on researching and reconstructing the shape and types of existing and legacy data in IndexedDB as well as how the current app consumes data, etc.purescript-indexeddb
.Attachment
type module passes existing unit tests.libphonenumber
Conversation.compareTitle
Avatar.hashCode
case
expressions and compile-time checking that all cases have been handled:toContactDetails
:Signal-Desktop/purescript/src/Signal/Components/ConversationList.purs
Lines 154 to 165 in 4ed4898
renderAvatar
:Signal-Desktop/purescript/src/Signal/Components/ConversationList.purs
Lines 178 to 180 in 4ed4898