Skip to content

Commit

Permalink
Upgrade to GraalVM 20.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
gastaldi committed Aug 26, 2020
1 parent b40e388 commit 90e2a0a
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 14 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/native-cron-build.yml.disabled
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: sudo systemctl stop mysql

- name: Pull docker image
run: docker pull quay.io/quarkus/ubi-quarkus-native-image:20.1.0-java${{ matrix.java }}
run: docker pull quay.io/quarkus/ubi-quarkus-native-image:20.2.0-java${{ matrix.java }}

- name: Set up JDK ${{ matrix.java }}
# Uses sha for added security since tags can be updated
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
run: mvn -B install -DskipTests -DskipITs -Dformat.skip

- name: Run integration tests in native
run: mvn -B --settings .github/mvn-settings.xml verify -f integration-tests/pom.xml --fail-at-end -Dno-format -Ddocker -Dnative -Dquarkus.native.container-build=true -Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-native-image:20.1.0-java${{ matrix.java }} -Dtest-postgresql -Dtest-elasticsearch -Dtest-mysql -Dtest-db2 -Dtest-amazon-services -Dtest-vault -Dtest-neo4j -Dtest-keycloak -Dtest-kafka -Dtest-mssql -Dtest-mariadb -Dmariadb.url="jdbc:mariadb://localhost:3308/hibernate_orm_test" -pl '!io.quarkus:quarkus-integration-test-google-cloud-functions-http,!io.quarkus:quarkus-integration-test-google-cloud-functions,!io.quarkus:quarkus-integration-test-funqy-google-cloud-functions'
run: mvn -B --settings .github/mvn-settings.xml verify -f integration-tests/pom.xml --fail-at-end -Dno-format -Ddocker -Dnative -Dquarkus.native.container-build=true -Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-native-image:20.2.0-java${{ matrix.java }} -Dtest-postgresql -Dtest-elasticsearch -Dtest-mysql -Dtest-db2 -Dtest-amazon-services -Dtest-vault -Dtest-neo4j -Dtest-keycloak -Dtest-kafka -Dtest-mssql -Dtest-mariadb -Dmariadb.url="jdbc:mariadb://localhost:3308/hibernate_orm_test" -pl '!io.quarkus:quarkus-integration-test-google-cloud-functions-http,!io.quarkus:quarkus-integration-test-google-cloud-functions,!io.quarkus:quarkus-integration-test-funqy-google-cloud-functions'

- name: Report
if: always()
Expand Down
2 changes: 1 addition & 1 deletion bom/application/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<maven-plugin-annotations.version>3.6.0</maven-plugin-annotations.version>
<plexus-component-annotations.version>2.1.0</plexus-component-annotations.version>
<!-- What we actually depend on for the annotations, as latest Graal is not available in Maven fast enough: -->
<graal-sdk.version>20.1.0</graal-sdk.version>
<graal-sdk.version>20.2.0</graal-sdk.version>
<gizmo.version>1.0.4.Final</gizmo.version>
<jackson.version>2.11.2</jackson.version>
<commons-logging-jboss-logging.version>1.0.0.Final</commons-logging-jboss-logging.version>
Expand Down
2 changes: 1 addition & 1 deletion build-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<!-- These properties are needed in order for them to be resolvable by the documentation -->
<!-- The Graal version we suggest using in documentation - as that's
what we work with by self downloading it: -->
<graal-sdk.version-for-documentation>20.1.0</graal-sdk.version-for-documentation>
<graal-sdk.version-for-documentation>20.2.0</graal-sdk.version-for-documentation>
<mandrel.version-for-documentation>20.1</mandrel.version-for-documentation>
<rest-assured.version>4.1.1</rest-assured.version>
<axle-client.version>1.1.0</axle-client.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public class NativeConfig {
/**
* The docker image to use to do the image build
*/
@ConfigItem(defaultValue = "quay.io/quarkus/ubi-quarkus-native-image:20.1.0-java11")
@ConfigItem(defaultValue = "quay.io/quarkus/ubi-quarkus-native-image:20.2.0-java11")
public String builderImage;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public NativeImageBuildItem build(NativeConfig nativeConfig, NativeImageSourceJa
final Process process = ProcessUtil.launchProcess(pb, processInheritIODisabled);
process.waitFor();
}
Boolean enableSslNative = false;
boolean enableSslNative = false;
for (NativeImageSystemPropertyBuildItem prop : nativeImageProperties) {
//todo: this should be specific build items
if (prop.getKey().equals("quarkus.ssl.native") && prop.getValue() != null) {
Expand Down Expand Up @@ -254,7 +254,8 @@ public NativeImageBuildItem build(NativeConfig nativeConfig, NativeImageSourceJa
.map(re -> "-H:IncludeResources=" + re.trim())
.forEach(command::add));
command.add("--initialize-at-build-time=");
command.add("-H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy$BySpaceAndTime"); //the default collection policy results in full GC's 50% of the time
command.add(
"-H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy$BySpaceAndTime"); //the default collection policy results in full GC's 50% of the time
command.add("-H:+JNI");
command.add("-jar");
command.add(runnerJarName);
Expand Down Expand Up @@ -579,8 +580,9 @@ static void safeWaitFor(Process process) {
intr = true;
}
} finally {
if (intr)
if (intr) {
Thread.currentThread().interrupt();
}
}
}

Expand Down Expand Up @@ -667,8 +669,12 @@ static final class Version implements Comparable<Version> {
Distribution.ORACLE);
static final Version SNAPSHOT_MANDREL = new Version("Snapshot", Integer.MAX_VALUE, Integer.MAX_VALUE,
Distribution.MANDREL);

static final Version VERSION_20_1 = new Version("GraalVM 20.1", 20, 1, Distribution.ORACLE);
static final Version CURRENT = VERSION_20_1;
static final Version VERSION_20_2 = new Version("GraalVM 20.2", 20, 2, Distribution.ORACLE);

static final Version MINIMUM = VERSION_20_1;
static final Version CURRENT = VERSION_20_2;

final String fullVersion;
final int major;
Expand All @@ -691,7 +697,7 @@ boolean isDetected() {
}

boolean isObsolete() {
return this.compareTo(CURRENT) < 0;
return this.compareTo(MINIMUM) < 0;
}

boolean isMandrel() {
Expand All @@ -708,14 +714,16 @@ boolean isNewerThan(Version version) {

@Override
public int compareTo(Version o) {
if (major > o.major)
if (major > o.major) {
return 1;
}

if (major == o.major) {
if (minor > o.minor)
if (minor > o.minor) {
return 1;
else if (minor == o.minor)
} else if (minor == o.minor) {
return 0;
}
}

return -1;
Expand Down
2 changes: 1 addition & 1 deletion independent-projects/bootstrap/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<shrinkwrap-depchain.version>1.2.6</shrinkwrap-depchain.version>
<jboss-logmanager-embedded.version>1.0.4</jboss-logmanager-embedded.version>
<slf4j-jboss-logging.version>1.2.0.Final</slf4j-jboss-logging.version>
<graal-sdk.version>20.1.0</graal-sdk.version>
<graal-sdk.version>20.2.0</graal-sdk.version>
<plexus-classworlds.version>2.6.0</plexus-classworlds.version> <!-- not actually used but ClassRealm class is referenced from the API used in BootstrapWagonConfigurator -->
<version.surefire.plugin>3.0.0-M5</version.surefire.plugin>
<smallrye-common.version>1.3.0</smallrye-common.version>
Expand Down

0 comments on commit 90e2a0a

Please sign in to comment.