This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
IBM JDK issues and non-ASCII characters in site's name #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,6 +50,9 @@ | |||
|
|
|||
| protected String cookiePrefix; | |||
|
|
|||
| // Service to encode the value of the cookie | |||
| private EncoderService encoderService; | |||
|
|
|||
| public RedirectCookieService(InitParams params) { | |||
There was a problem hiding this comment.
You can just pass the EncoderService as part of the constructor.
|
Seems like the drag & drop logic should be updated to handle the negative id instead of having these special checks all over the place which will just result in this issue arising again. |
|
merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.