This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
GTNPORTAL-3323 UI should reflect changes when data is modified through backend services #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
|
||
| if (config instanceof PortalConfig || config instanceof Container) { | ||
| //Update a layout, it should clear cache | ||
| manager.clearCache(); |
There was a problem hiding this comment.
I have concerns about performance. Would it make more sense to remove the key that is effected instead of clearing the entire cache ?
There was a problem hiding this comment.
As I commented in JIRA, updating layout is not such a frequently action, so I think it's not a real performance issue
|
Nick says this pull request is good to go. Could you please merge it if possible? |
|
Merged to master and 3.6.x. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.