Store cart in cookie instead of HttpSession #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Effort to reduce server memory usage
Isammoc
reviewed
Jan 21, 2023
|
|
||
| @Controller | ||
| @RequestMapping("/cart") | ||
| @SuppressWarnings("unchecked") | ||
| public class CartController { | ||
|
|
||
| public static final class Carts { |
There was a problem hiding this comment.
nit: Should not be in Controller.
public static final class => should be a top class in its own file
| @@ -1,19 +1,21 @@ | |||
| package io.gatling.demostore; | |||
There was a problem hiding this comment.
First line of first changed file: only to have a closable thread.
I think we should change the session management instead of a workaround like that.
The cart being in the session is a normal usage of the session.
The session being stored in the server is not.
Either an accessible cache (ie memcache or redis) or using session from cookie (like Play does)
First quick search on the topic:
There was a problem hiding this comment.
|
|
||
| } else { | ||
| HashMap<Integer, Cart> cart = (HashMap<Integer, Cart>) session.getAttribute("cart"); | ||
| cart = Carts.fromCookieValue(cartCookie); |
There was a problem hiding this comment.
Shouldn't fromCookieValue to manage the case that cartCookie is null?
Comment on lines
74
to
+78
| if (cart.containsKey(id)) { | ||
| int qty = cart.get(id).getQuantity(); | ||
| cart.put(id, new Cart(id, product.getName(), product.getPrice(), ++qty, product.getImage())); | ||
| cart.put(id, new CartEntry(id, product.getName(), product.getPrice(), ++qty, product.getImage())); | ||
| } else { | ||
| cart.put(id, new Cart(id, product.getName(), product.getPrice(), 1, product.getImage())); | ||
| session.setAttribute("cart", cart); | ||
| cart.put(id, new CartEntry(id, product.getName(), product.getPrice(), 1, product.getImage())); |
There was a problem hiding this comment.
Suggested change
| if (cart.containsKey(id)) { | |
| int qty = cart.get(id).getQuantity(); | |
| cart.put(id, new Cart(id, product.getName(), product.getPrice(), ++qty, product.getImage())); | |
| cart.put(id, new CartEntry(id, product.getName(), product.getPrice(), ++qty, product.getImage())); | |
| } else { | |
| cart.put(id, new Cart(id, product.getName(), product.getPrice(), 1, product.getImage())); | |
| session.setAttribute("cart", cart); | |
| cart.put(id, new CartEntry(id, product.getName(), product.getPrice(), 1, product.getImage())); | |
| int qty = cart.containsKey(id) ? cart.get(id).getQuantity() : 0; | |
| cart.put(id, new CartEntry(id, product.getName(), product.getPrice(), qty + 1, product.getImage())); |
Comment on lines
+203
to
+214
| private static void updateCartCookie(HttpServletResponse response, Map<Integer, CartEntry> cart) throws IOException { | ||
| Cookie cookie = new Cookie(Carts.COOKIE_NAME, Carts.toCookieValue(cart)); | ||
| cookie.setPath("/"); | ||
| response.addCookie(cookie); | ||
| } | ||
|
|
||
| private static void removeCartCookie(HttpServletResponse response) { | ||
| Cookie cookie = new Cookie(Carts.COOKIE_NAME, ""); | ||
| cookie.setMaxAge(0); | ||
| cookie.setPath("/"); | ||
| response.addCookie(cookie); | ||
| } |
|
|
||
| public static Map<Integer, CartEntry> fromCookieValue(String cookieValue) throws IOException { | ||
| if (cookieValue == null) { | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| return new HashMap<>(); |
|
|
||
| private static TypeReference<Map<Integer, CartEntry>> CART_TYPE = new TypeReference<Map<Integer, CartEntry>>() {}; | ||
|
|
||
| public static Map<Integer, CartEntry> fromCookieValue(String cookieValue) throws IOException { |
There was a problem hiding this comment.
Suggested change
| public static Map<Integer, CartEntry> fromCookieValue(String cookieValue) throws IOException { | |
| public static Map<Integer, CartEntry> fromCookieValue(String cookieValue) { |
| return null; | ||
| } | ||
|
|
||
| return JACKSON.readValue(Base64.getDecoder().decode(cookieValue), CART_TYPE); |
There was a problem hiding this comment.
Suggested change
| return JACKSON.readValue(Base64.getDecoder().decode(cookieValue), CART_TYPE); | |
| try { | |
| return JACKSON.readValue(Base64.getDecoder().decode(cookieValue), CART_TYPE); | |
| } catch (IOException e) { | |
| return new HashMap<>(); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Effort to reduce server memory usage