Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove automatic maven central configuration, #4259 #56

Merged
merged 1 commit into from Jun 17, 2022

Conversation

Isammoc
Copy link
Member

@Isammoc Isammoc commented Jun 17, 2022

Motivation:
Flaky tests and out of scope feature

Modifications:

  • Remove automatic maven central configuration
  • Display an explicit message when gatling dependencies are not reachable

Result:
Limit scope

Closes gatling/gatling#4259

Motivation:
Flaky tests and out of scope feature

Modifications:
 * Remove automatic maven central configuration
 * Display an explicit message when gatling dependencies are not reachable

Result:
Limit scope

Closes gatling/gatling#4259
Copy link
Member

@slandelle slandelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
That was originally a bad idea of mine.

@slandelle slandelle merged commit 6ba5824 into main Jun 17, 2022
@slandelle slandelle deleted the 4259-remove-automatic-maven-central branch June 17, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants