Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP: Should not be send Content-Type when is used http method without payload when use asXXX() #4429

Closed
gemiusz opened this issue Jun 1, 2023 · 2 comments
Closed

HTTP: Should not be send Content-Type when is used http method without payload when use asXXX() #4429

gemiusz opened this issue Jun 1, 2023 · 2 comments
Assignees
@slandelle
Labels
Module - HTTP Type - Feature
Milestone
3.10.0

Comments

@gemiusz
Copy link
Contributor

gemiusz commented Jun 1, 2023

Regarding to RFC7231 Section 3.1.1.5 when is used asXXX() when is creating request should be checked if request have .body() if not there shouldn't be set header content-type.
At this moment is always set.
@slandelle
Copy link
Member

Mixed feelings: asJson is clearly documented as a shortcut for

http("name").post("/")
  .header("accept", "application/json")
  .header("content-type", "application/json")

But then, people often don't read the documentation...

@slandelle slandelle self-assigned this Aug 14, 2023
@slandelle slandelle added this to the 3.10.0 milestone Aug 14, 2023
@slandelle
Copy link
Member

I ended up favoring ease of use for the end user and doing as you advised.

Thanks @gemiusz !

slandelle added a commit that referenced this issue Aug 14, 2023
@slandelle
Remove content-type header when the request doesn't have a body, close
70d4f20 
 #4429

Motivation:

Users might use `asXxx` even when they're not passing a body, just to define the `accept` header.

Modification:

Remove `content-type` when the request doesn't have a body.
@slandelle slandelle modified the milestones: 3.10.1, 3.10.0 Nov 11, 2023
@slandelle slandelle mentioned this issue Dec 19, 2023
Closed
@slandelle slandelle mentioned this issue Jan 15, 2024
Closed
slandelle added a commit that referenced this issue Jan 15, 2024
@slandelle
Revert aggressively removing request content-type header when request…
6e9b861 
… body is empty, close #4509

Motivation:

As of #4429, we're aggressively removing request content-type header when request body is empty.
This is wrong, some content-types have valid empty string value, such as application/x-www-form-urlencoded.

Let's only not add a request content-type when using asJson and asXml when there's no body as an empty string is not a valid content for these encodings.

Modification:

Introduce HeadersBuiltIn that's only resolved when building the request.
slandelle added a commit that referenced this issue Jan 15, 2024
@slandelle
Revert aggressively removing request content-type header when request…
83ad800 
… body is empty, close #4509

Motivation:

As of #4429, we're aggressively removing request content-type header when request body is empty.
This is wrong, some content-types have valid empty string value, such as application/x-www-form-urlencoded.

Let's only not add a request content-type when using asJson and asXml when there's no body as an empty string is not a valid content for these encodings.

Modification:

Introduce HeadersBuiltIn that's only resolved when building the request.
slandelle added a commit that referenced this issue Jan 19, 2024
@slandelle
Revert aggressively removing request content-type header when request…
f36f395 
… body is empty, close #4509

Motivation:

As of #4429, we're aggressively removing request content-type header when request body is empty.
This is wrong, some content-types have valid empty string value, such as application/x-www-form-urlencoded.

Let's only not add a request content-type when using asJson and asXml when there's no body as an empty string is not a valid content for these encodings.

Modification:

Introduce HeadersBuiltIn that's only resolved when building the request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
Module - HTTP Type - Feature
Milestone
3.10.0
Development

No branches or pull requests
2 participants
@slandelle @gemiusz