HTTP: revert aggressively removing request content-type header when request body is empty #4509
Comments
slandelle
added a commit
that referenced
this issue
Jan 15, 2024
… body is empty, close #4509 Motivation: As of #4429, we're aggressively removing request content-type header when request body is empty. This is wrong, some content-types have valid empty string value, such as application/x-www-form-urlencoded. Let's only not add a request content-type when using asJson and asXml when there's no body as an empty string is not a valid content for these encodings. Modification: Introduce HeadersBuiltIn that's only resolved when building the request.
slandelle
added a commit
that referenced
this issue
Jan 19, 2024
… body is empty, close #4509 Motivation: As of #4429, we're aggressively removing request content-type header when request body is empty. This is wrong, some content-types have valid empty string value, such as application/x-www-form-urlencoded. Let's only not add a request content-type when using asJson and asXml when there's no body as an empty string is not a valid content for these encodings. Modification: Introduce HeadersBuiltIn that's only resolved when building the request.
slandelle
added a commit
that referenced
this issue
Feb 9, 2024
slandelle
added a commit
that referenced
this issue
Feb 9, 2024
slandelle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of #4429, we're aggressively removing request content-type header when request body is empty.
This is wrong, some content-types have valid empty string value, such as
application/x-www-form-urlencoded.Let's only not add a request content-type when using
asJsonandasXmlwhen there's no body as an empty string is not a valid content for these encodings.The text was updated successfully, but these errors were encountered: