Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bengali translation of code-of-conduct #2

Merged
merged 3 commits into from Jan 20, 2020
Merged

Add Bengali translation of code-of-conduct #2

merged 3 commits into from Jan 20, 2020

Conversation

ayan-b
Copy link
Contributor

@ayan-b ayan-b commented Jan 17, 2020

Related to #1

Copy link
Contributor

@shakib609 shakib609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate the whole portion in a single line otherwise it's quite hard to review further.

docs/contributing/code-of-conduct.md Outdated Show resolved Hide resolved
docs/contributing/code-of-conduct.md Outdated Show resolved Hide resolved
@ayan-b
Copy link
Contributor Author

ayan-b commented Jan 18, 2020

Translate the whole portion in a single line otherwise it's quite hard to review further.

I do not really know the style guide followed here, but it is, in general, a good idea to follow an 80 character limit for a single line (ref). Let me know if it is followed here or not.

In the English files, it is not followed. I will translate a whole paragraph in a single line. Thanks!

@ayan-b ayan-b changed the title Add bengali translation of code-of-conduct Add Bengali translation of code-of-conduct Jan 18, 2020
@ayan-b
Copy link
Contributor Author

ayan-b commented Jan 20, 2020

@nutboltu @shakib609 Please review and let me know if something needs changing.

Copy link
Contributor

@nutboltu nutboltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

despite some spacing issue, looks good!
Good work @ayan-b

@ayan-b
Copy link
Contributor Author

ayan-b commented Jan 20, 2020

@shakib609 Please review and let me know something needs to be changed.

@shakib609
Copy link
Contributor

Looks good. Merging.
Great work!

@shakib609 shakib609 merged commit 6f20e47 into gatsbyjs:master Jan 20, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 20, 2020

Holy buckets, @ayan-b — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@ayan-b ayan-b deleted the add-coc branch January 21, 2020 00:58
@gatsbybot gatsbybot mentioned this pull request Jan 28, 2020
46 tasks
@ayan-b ayan-b self-assigned this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants