Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial part four #99

Merged
merged 23 commits into from
Oct 24, 2019
Merged

Conversation

rubenLozanoMar
Copy link
Contributor

Added translation for tutorial part four
Ready for review

@rubenLozanoMar rubenLozanoMar mentioned this pull request Oct 18, 2019
24 tasks
@jorgeruvalcaba jorgeruvalcaba added the Ready for review Pull request is ready for a maintainer to review it label Oct 18, 2019
Copy link
Contributor

@xmartinezpujol xmartinezpujol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy buena traducción.

Así importante sólo veo un pequeño salto de línea a poner/quitar en la parte superior del código para que coincidan los números de línea entre traducciones.

El resto excelente, ¡gran trabajo! @rubenLozanoMar 💪

docs/tutorial/part-four/index.md Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
@xmartinezpujol xmartinezpujol self-assigned this Oct 21, 2019
@xmartinezpujol xmartinezpujol added this to the Tutorials Translation milestone Oct 21, 2019
@horacioh
Copy link
Contributor

@Darking360 te puedes encargar de esta?
gracias!

@gatsbyjs gatsbyjs deleted a comment from xmartinezpujol Oct 22, 2019
@gatsbyjs gatsbyjs deleted a comment from xmartinezpujol Oct 22, 2019
@gatsbyjs gatsbyjs deleted a comment from xmartinezpujol Oct 22, 2019
Copy link
Contributor

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @rubenLozanoMar muchas gracias por la contribución, te deje unos comentarios adicionales a los que dejo @xmartinezpujol, lo importante es que hay pequeños detalles pero lo importante es que las lineas no corresponde, el archivo original tiene 379 lineas, este tiene 347, deben quedar iguales pero con sus correspondientes lineas traducidas, vi que las que estaban separadas en saltos de lineas, las uniste, deben ser linea a linea 💪 Eso y unas partes que no estaban traducidas que corresponden a atributos/descripciones de imágenes. Cuando agregues esto podemos hacerle merge 🚀 Gracias 🙏

docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
integers (`42`), objects (`{ pizza: true }`), etc.

For the purpose of working in Gatsby, however, a more useful answer is
"everything that lives outside a React component".
Para el trabajo en Gatsby, por otra parte, una forma de responder más útil es: "todo lo que reside fuera de un componente React"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Para el trabajo en Gatsby, por otra parte, una forma de responder más útil es: "todo lo que reside fuera de un componente React"
Para el propósito en Gatsby, por otra parte, una forma más útil de responder es: "todo lo que reside fuera de un componente React"

docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-four/index.md Outdated Show resolved Hide resolved
@xmartinezpujol xmartinezpujol added in review and removed Ready for review Pull request is ready for a maintainer to review it labels Oct 23, 2019
@rubenLozanoMar
Copy link
Contributor Author

Ajustadas las líneas y las frases que faltaba por traducir, tendré más cuidado con los ajustes de las lineas para los próximos.

@xmartinezpujol xmartinezpujol merged commit 877b22e into gatsbyjs:master Oct 24, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 24, 2019

Holy buckets, @rubenLozanoMar — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants