fix(gatsby-transformer-sharp): create child nodes only for Files (#27992

)
gatsbyjs · Nov 12, 2020 · 001e045 · 001e045
1 parent 3fda83b
commit 001e045
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 7 deletions.
diff --git a/packages/gatsby-transformer-sharp/src/__tests__/__snapshots__/gatsby-node.js.snap b/packages/gatsby-transformer-sharp/src/__tests__/__snapshots__/gatsby-node.js.snap
@@ -35,13 +35,10 @@ Array [
         "id": "whatever",
         "internal": Object {
           "contentDigest": "whatever",
+          "type": "File",
         },
       },
     },
   ],
 ]
 `;
-
-exports[`Process image nodes correctly doesn't create an ImageSharp node for a .gif file 1`] = `Array []`;
-
-exports[`Process image nodes correctly doesn't create an ImageSharp node for a .gif file 2`] = `Array []`;
diff --git a/packages/gatsby-transformer-sharp/src/__tests__/gatsby-node.js b/packages/gatsby-transformer-sharp/src/__tests__/gatsby-node.js
@@ -8,6 +8,7 @@ describe(`Process image nodes correctly`, () => {
       children: [],
       internal: {
         contentDigest: `whatever`,
+        type: `File`,
       },
     }
     const createNode = jest.fn()
@@ -34,6 +35,33 @@ describe(`Process image nodes correctly`, () => {
       children: [],
       internal: {
         contentDigest: `whatever`,
+        type: `File`,
+      },
+    }
+    const createNode = jest.fn()
+    const createParentChildLink = jest.fn()
+    const actions = { createNode, createParentChildLink }
+    const createNodeId = jest.fn()
+    createNodeId.mockReturnValue(`uuid-from-gatsby`)
+
+    await onCreateNode({
+      node,
+      actions,
+      createNodeId,
+    }).then(() => {
+      expect(createNode).toHaveBeenCalledTimes(0)
+      expect(createParentChildLink).toHaveBeenCalledTimes(0)
+    })
+  })
+
+  it(`doesn't create an ImageSharp node if parent is not a File`, async () => {
+    const node = {
+      extension: `png`,
+      id: `whatever`,
+      children: [],
+      internal: {
+        contentDigest: `whatever`,
+        type: `NotAFile`,
       },
     }
     const createNode = jest.fn()
@@ -47,8 +75,6 @@ describe(`Process image nodes correctly`, () => {
       actions,
       createNodeId,
     }).then(() => {
-      expect(createNode.mock.calls).toMatchSnapshot()
-      expect(createParentChildLink.mock.calls).toMatchSnapshot()
       expect(createNode).toHaveBeenCalledTimes(0)
       expect(createParentChildLink).toHaveBeenCalledTimes(0)
     })

diff --git a/packages/gatsby-transformer-sharp/src/on-node-create.js b/packages/gatsby-transformer-sharp/src/on-node-create.js
@@ -1,7 +1,7 @@
 const { supportedExtensions } = require(`./supported-extensions`)
 
 function unstable_shouldOnCreateNode({ node }) {
-  return !!supportedExtensions[node.extension]
+  return node.internal.type === `File` && !!supportedExtensions[node.extension]
 }
 
 module.exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode