feat(gatsby-plugin-sharp): cache image metadata (#35791)

gatsbyjs · Jun 1, 2022 · 7d93d2e · 7d93d2e
1 parent b802061
commit 7d93d2e
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 7 deletions.
diff --git a/e2e-tests/development-runtime/cypress/integration/hot-reloading/new-file.js b/e2e-tests/development-runtime/cypress/integration/hot-reloading/new-file.js
@@ -6,7 +6,9 @@ describe(`client-side navigation to the new page`, () => {
   })
 
   it(`can navigate to newly created page using link`, () => {
-    cy.findByTestId(`hot-reloading-new-file`).click().waitForRouteChange()
+    cy.findByTestId(`hot-reloading-new-file`)
+      .click({ force: true })
+      .waitForRouteChange()
     cy.getTestElement(`message`).invoke(`text`).should(`contain`, `Hello`)
   })
 })

diff --git a/packages/gatsby-plugin-sharp/src/image-data.ts b/packages/gatsby-plugin-sharp/src/image-data.ts
@@ -36,14 +36,25 @@ const metadataCache = new Map<string, IImageMetadata>()
 
 export async function getImageMetadata(
   file: FileNode,
-  getDominantColor?: boolean
+  getDominantColor?: boolean,
+  cache?: GatsbyCache
 ): Promise<IImageMetadata> {
   if (!getDominantColor) {
     // If we don't need the dominant color we can use the cheaper size function
     const { width, height, type } = await getImageSizeAsync(file)
     return { width, height, format: type }
   }
-  let metadata = metadataCache.get(file.internal.contentDigest)
+
+  let metadata: IImageMetadata | undefined
+  const METADATA_KEY = `metadata-${file.internal.contentDigest}`
+
+  if (cache) {
+    // Use plugin cache
+    metadata = await cache.get(METADATA_KEY)
+  } else {
+    // Use in-memory cache instead
+    metadata = metadataCache.get(METADATA_KEY)
+  }
   if (metadata && process.env.NODE_ENV !== `test`) {
     return metadata
   }
@@ -62,7 +73,11 @@ export async function getImageMetadata(
       : `#000000`
 
     metadata = { width, height, density, format, dominantColor }
-    metadataCache.set(file.internal.contentDigest, metadata)
+    if (cache) {
+      await cache.set(METADATA_KEY, metadata)
+    } else {
+      metadataCache.set(METADATA_KEY, metadata)
+    }
   } catch (err) {
     reportError(`Failed to process image ${file.absolutePath}`, err)
     return {}
@@ -131,7 +146,11 @@ export async function generateImageData({
     )
   }
 
-  const metadata = await getImageMetadata(file, placeholder === `dominantColor`)
+  const metadata = await getImageMetadata(
+    file,
+    placeholder === `dominantColor`,
+    cache
+  )
 
   if ((args.width || args.height) && layout === `fullWidth`) {
     reporter.warn(
@@ -259,7 +278,11 @@ export async function generateImageData({
   if (!images?.length) {
     return undefined
   }
-  const imageProps: IGatsbyImageData = {
+  const imageProps: Pick<
+    IGatsbyImageData,
+    "backgroundColor" | "layout" | "placeholder" | "images"
+  > &
+    Partial<Pick<IGatsbyImageData, "width" | "height">> = {
     layout,
     placeholder: undefined,
     backgroundColor,
@@ -380,5 +403,5 @@ export async function generateImageData({
       imageProps.width = args.width || primaryImage.width || 1
       imageProps.height = (imageProps.width || 1) / primaryImage.aspectRatio
   }
-  return imageProps
+  return imageProps as IGatsbyImageData
 }