Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Site showcase] Visit site buttons are not mobile responsive #10242

Closed
daydream05 opened this issue Dec 2, 2018 · 5 comments
Closed

[Site showcase] Visit site buttons are not mobile responsive #10242

daydream05 opened this issue Dec 2, 2018 · 5 comments

Comments

@daydream05
Copy link
Contributor

When you visit a site showcase the "visit site" buttons are blocking the "source code" button as seen here.

screen shot 2018-12-02 at 1 43 47 pm

Based on this design by @fk this is how it's supposed to look

https://projects.invisionapp.com/share/T9H9LRCG8Z5#/screens/292717378

screen shot 2018-12-02 at 1 47 41 pm
@daydream05
Copy link
Contributor Author

This should be a quick fix. I'll be happy to do a PR

@daydream05
Copy link
Contributor Author

Please no one else fix this. This is probably the only PR i can do 😂

daydream05 added a commit to daydream05/gatsby that referenced this issue Dec 3, 2018
@daydream05
Fix showcase visit site link overlap
13d34e5 
It fixes this issue gatsbyjs#10242

- Only moved the top position so it’s not blocking the github button
- Kept the original layout when it goes back to desktop
@daydream05 daydream05 mentioned this issue Dec 3, 2018
Merged
@gatsbot
Copy link

gatsbot bot commented Feb 4, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 4, 2019
@wardpeet wardpeet added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Feb 13, 2019
@wardpeet
Copy link
Contributor

cleaning up the PR and getting it merged

wardpeet pushed a commit that referenced this issue Feb 15, 2019
@daydream05 @wardpeet
fix(www): Fix showcase visit site link overlap (#10249)
5d6f13f 
* Fix showcase visit site link overlap

It fixes this issue #10242

- Only moved the top position so it’s not blocking the github button
- Kept the original layout when it goes back to desktop

* added trailing comma to comply with prettier

* moar trailing comma

* cleanup css to hide or show visit button
@wardpeet
Copy link
Contributor

@daydream05 thank you for starting on this PR. We finally got it merged!

gatsbybot pushed a commit to gatsbyjs/gatsby-starter-blog that referenced this issue Feb 15, 2019
fix(www): Fix showcase visit site link overlap (#10249)
41fc093 
* Fix showcase visit site link overlap

It fixes this issue gatsbyjs/gatsby#10242

- Only moved the top position so it’s not blocking the github button
- Kept the original layout when it goes back to desktop

* added trailing comma to comply with prettier

* moar trailing comma

* cleanup css to hide or show visit button
gatsbybot pushed a commit to gatsbyjs/gatsby-starter-default that referenced this issue Feb 15, 2019
fix(www): Fix showcase visit site link overlap (#10249)
8a52478 
* Fix showcase visit site link overlap

It fixes this issue gatsbyjs/gatsby#10242

- Only moved the top position so it’s not blocking the github button
- Kept the original layout when it goes back to desktop

* added trailing comma to comply with prettier

* moar trailing comma

* cleanup css to hide or show visit button
ish-xyz pushed a commit to ish-xyz/ish-ar.io that referenced this issue Dec 5, 2019
fix(www): Fix showcase visit site link overlap (#10249)
98f53cd 
* Fix showcase visit site link overlap

It fixes this issue gatsbyjs/gatsby#10242

- Only moved the top position so it’s not blocking the github button
- Kept the original layout when it goes back to desktop

* added trailing comma to comply with prettier

* moar trailing comma

* cleanup css to hide or show visit button
idev-a added a commit to idev-a/landing-page-gatsby that referenced this issue Dec 14, 2020
@idev-a
fix(www): Fix showcase visit site link overlap (#10249)
77ba064 
* Fix showcase visit site link overlap

It fixes this issue gatsbyjs/gatsby#10242

- Only moved the top position so it’s not blocking the github button
- Kept the original layout when it goes back to desktop

* added trailing comma to comply with prettier

* moar trailing comma

* cleanup css to hide or show visit button
goldenjake pushed a commit to goldenjake/gatsby-starter-default that referenced this issue May 19, 2022
fix(www): Fix showcase visit site link overlap (#10249)
475fa92 
* Fix showcase visit site link overlap

It fixes this issue gatsbyjs/gatsby#10242

- Only moved the top position so it’s not blocking the github button
- Kept the original layout when it goes back to desktop

* added trailing comma to comply with prettier

* moar trailing comma

* cleanup css to hide or show visit button
leonhiat added a commit to leonhiat/gatsby-starter-blog that referenced this issue Oct 31, 2023
@leonhiat
fix(www): Fix showcase visit site link overlap (#10249)
f070192 
* Fix showcase visit site link overlap

It fixes this issue gatsbyjs/gatsby#10242

- Only moved the top position so it’s not blocking the github button
- Kept the original layout when it goes back to desktop

* added trailing comma to comply with prettier

* moar trailing comma

* cleanup css to hide or show visit button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wardpeet @daydream05 @LekoArts