[Regression] createRemoteFileNode is not able to guess filename from temporary urls #11037
Comments
|
Ok i felt quite confident you will accept my proposal and since it was changing a couple of lines i went one small step further and PRed it |
|
I think it makes sense to have an override as there are lots of different use case of this utility method and there is no way to cater for each and every use case. Thanks for proposing this @oorestisime |
DSchau
pushed a commit
that referenced
this issue
Jan 23, 2019
…RemoteFileNode (#11054) Fix: #11037 <!-- Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> ## Description Take an optional name parameter to fix issue with temporary urls having no "guessable" name <!-- Write a brief description of the changes introduced by this PR --> ## Related Issues <!-- Link to the issue that is fixed by this PR (if there is one) e.g. Fixes #1234, Addresses #1234, Related to #1234, etc. -->
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this issue
Apr 20, 2023
…RemoteFileNode (gatsbyjs#11054) Fix: gatsbyjs#11037 <!-- Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> ## Description Take an optional name parameter to fix issue with temporary urls having no "guessable" name <!-- Write a brief description of the changes introduced by this PR --> ## Related Issues <!-- Link to the issue that is fixed by this PR (if there is one) e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(Sorry for not respecting the template)
So #9777 introduced a regression when the It tries to guess the remote file name on urls that do not contain the filename. Such urls are temporary download urls. I guess this is acceptable
But when those urls are somewhat long (>255 characters) then it will try to save the file under that name and fail since it exceeds the maximum characters allowed in a filename (255 on ext4).
Proposal: same thing with the extension, the
createRemoteFileNodecould take an optional parameter that enforces the name of the file.If this is ok I am willing to make the necessary changes here.
(How i came here oorestisime/gatsby-source-dropbox#2)
The text was updated successfully, but these errors were encountered: