Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot module replacement not working in IE #11495

Closed
saranshkataria opened this issue Feb 2, 2019 · 8 comments · Fixed by #11582
Closed

Hot module replacement not working in IE #11495

saranshkataria opened this issue Feb 2, 2019 · 8 comments · Fixed by #11582
Labels
stale? Issue that may be closed soon due to the original author not responding any more. status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby

Comments

@saranshkataria
Copy link
Contributor

Description

I get a console error: webpack-hot-middleware's client requires EventSource to work. You should include a polyfill if you want to support this browser: https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events#Tools

Steps to reproduce

  1. Create new project
  2. Run gatsby develop
  3. open IE
  4. (warning shows in console)

Expected result

HMR should work in IE

Actual result

HMR is not working

@saranshkataria
Copy link
Contributor Author

Seems like event-source-polyfill needs to be added to the project and then an entry needs to be made in the webpack config for importing it before importing webpack-hot-middleware/client. If I am on the right track, would like to create a PR for it

@sidharthachatterjee
Copy link
Contributor

So isn't supported on IE or Edge according to https://caniuse.com/#feat=eventsource

@saranshkataria Thank you for the debugging on this. We'd love to receive a PR!

@sidharthachatterjee sidharthachatterjee added type: bug An issue or pull request relating to a bug in Gatsby status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. labels Feb 4, 2019
@saranshkataria
Copy link
Contributor Author

I will start working on it

wardpeet pushed a commit that referenced this issue Feb 13, 2019
…11582)

fixes #11495

## Description

Added event source polyfill in develop mode for IE. I am not sure how to test the CLI after making these changes, would need some pointers for that.

Co-authored-by: Dustin Schau <DSchau@users.noreply.github.com>
gurpreet-hanjra pushed a commit to gurpreet-hanjra/gatsby that referenced this issue Feb 14, 2019
…atsbyjs#11582)

fixes gatsbyjs#11495

## Description

Added event source polyfill in develop mode for IE. I am not sure how to test the CLI after making these changes, would need some pointers for that.

Co-authored-by: Dustin Schau <DSchau@users.noreply.github.com>
@JodiWarren
Copy link

This seems to have regressed at some point. In IE11, I get the same message as in the original post: webpack-hot-middleware's client requires EventSource to work. I haven't yet worked out whether this is an issue upstream or in Gatsby's implementation.

@sidharthachatterjee
Copy link
Contributor

@JodiWarren Interesting. Let me reopen this if that's the case.

I haven't yet worked out whether this is an issue upstream or in Gatsby's implementation.

Do let us know if you manage to work this out!

@chandlervdw
Copy link

chandlervdw commented Jan 16, 2020

This seems to have regressed at some point.

+1 this polyfill no longer works. @JodiWarren any luck tracking down if this is upstream or within Gatbsy?

@github-actions
Copy link

github-actions bot commented Feb 6, 2020

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 6, 2020
@github-actions
Copy link

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this issue Apr 28, 2022
…atsbyjs#11582)

fixes gatsbyjs#11495

## Description

Added event source polyfill in develop mode for IE. I am not sure how to test the CLI after making these changes, would need some pointers for that.

Co-authored-by: Dustin Schau <DSchau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants