feat(createRemoteFileNode): allow passing headers to request

[iFlameing]

Description

This allows a user to pass header to create-remote-file-node for fetching data which is in private mode in cms.

thanks to @datakurre who also helped me in creating this pr.

[iFlameing]

@pieh can you review this?

[iFlameing]

@pieh I think it needs review once again.

[iFlameing]

@pieh can you review this? this is quiet simple.

[datakurre]

@iFlameing Unfortunately, you need to rebase this.

It also seems that passing headers forward from requestRemoteNode has now been fixed in master, so renaming headers to requestArgs is no longer required. So, IMO this fix could be even simpler (just replacing const headers = {} with that headers argument).

[iFlameing]

@datakurre once I get a reply from @wardpeet I will rebase this pr and do the necessary changes as you said.

[iFlameing]

@datakurre I rebased the pr and modified the changes as you suggested. Please take a look!

[iFlameing]

@pieh, please! review this once again.

[pieh]

I think this looks good, but I didn't actually tested as I don't have anything that require some specific headers to download files - so to merge I need some example to test against

[iFlameing]

@pieh We already tested this for downloading private images from Plone Source. Here is the link of issue where we tested it collective/gatsby-source-plone#162.

[wardpeet]

i'll test with a simple glitch site.

[wardpeet]

Tested with https://judicious-dinghy.glitch.me/secret & https://github.com/gatsbyjs/gatsby/tree/master/examples/using-gatsby-image it works as expected. When the authorization header is not present I get a no access image and else I get authorized!

[gatsbot]

Holy buckets, @iFlameing — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

[sidharthachatterjee]

Published in gatsby-source-filesystem@2.0.29