Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gastby site brokes when try to search dependency #21916

Closed
afucher opened this issue Mar 2, 2020 · 1 comment · Fixed by #21927
Closed

Gastby site brokes when try to search dependency #21916

afucher opened this issue Mar 2, 2020 · 1 comment · Fixed by #21927
Assignees
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@afucher
Copy link

afucher commented Mar 2, 2020

Description

When try to search for starters that use some plugin, the site broke and just show a blank page.
example: https://www.gatsbyjs.org/starters/?d=gatsby-source-googlemaps-static&v=2

Steps to reproduce

Enter in the plugin search page, click on any plugin and then click on the See starters using this link.

Expected result

I should see a page with the result of the search.

Actual result

It shows a blank page

Environment

@afucher afucher added the type: bug An issue or pull request relating to a bug in Gatsby label Mar 2, 2020
@pvdz
Copy link
Contributor

pvdz commented Mar 3, 2020

Hi @afucher. Thanks for your report.

I've confirmed the problem. Trace:

Bug introduced in fda78f1#diff-51865a2ea87f4bfd5fb20a85ed340a9bL25 by #21792
Then #21876 tried to fix it which is leading to the current problem where the node does not have the property that was read from the edge in filterByDependencies in gatsby/www/src/views/starter-library/filtered-starters.js and therefor this breaks

  starters = starters.filter(
    ({ node: starter }) =>
      starter.fields &&

@pvdz pvdz self-assigned this Mar 3, 2020
pvdz added a commit that referenced this issue Mar 3, 2020
)

* Rename variable

* fix(gatsby/www): Property access regression in starters

Fix #21916

* Refactor for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants