Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass react router path matching #222

Closed
KyleAMathews opened this issue Mar 29, 2016 · 4 comments
Closed

Bypass react router path matching #222

KyleAMathews opened this issue Mar 29, 2016 · 4 comments
Labels
help wanted Issue with a clear description that the community can help with.
Milestone

Comments

@KyleAMathews
Copy link
Contributor

I discovered recently that react-router can be very slow at matching routes remix-run/react-router#3215

This will soon be (mostly) fixed but there'll still be 10-15 milliseconds spent matching the router (that's on a 2015 MBP so much much slower on an old android) that we should avoid.

We can load our own routing table into the browser and match path changes against that which will drop path matching times down to microseconds.

This will also probably make code splitting more convenient #10

@taion
Copy link

taion commented Apr 8, 2016

This will be cleaner with remix-run/react-router#3262.

@taion
Copy link

taion commented Apr 13, 2016

As of React Router v2.2.0, getComponent now gets called with the router state, including params.

@KyleAMathews
Copy link
Contributor Author

This is great! Thanks!

@KyleAMathews KyleAMathews added help wanted Issue with a clear description that the community can help with. Hacktoberfest labels Oct 12, 2016
@KyleAMathews KyleAMathews added this to the 1.0 milestone Oct 12, 2016
@KyleAMathews
Copy link
Contributor Author

Closing as very old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with.
Projects
None yet
Development

No branches or pull requests

3 participants